Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting direct_running_mode for LocalDirectRunner #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuvipanda
Copy link
Collaborator

This also changes the default local one from multi_processing to multi_threading. The primary use here is to make the logging config from the runner be inherited by the workers too, which helps with debugging quite a bit.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0eda0ca) 96.46% compared to head (ff36901) 96.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   96.46%   96.47%           
=======================================
  Files          15       15           
  Lines         509      510    +1     
=======================================
+ Hits          491      492    +1     
  Misses         18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuvipanda
Copy link
Collaborator Author

#66 sets the logging config

@yuvipanda yuvipanda closed this Aug 19, 2023
@yuvipanda yuvipanda reopened this Aug 19, 2023
@yuvipanda
Copy link
Collaborator Author

Changing this default would reduce multi-core performance when running locally, so maybe let's hold off for a second.

@moradology
Copy link
Contributor

Hey Yuvi - going through and attempting to get things aligned and cleaned up in terms of PRs and I'm wondering if maybe we should just accept the default of multi_processing but keep the configurable argument so that it is easier to enable the more debug-friendly multi_threading case?

This also changes the default local one from multi_processing
to multi_threading. The primary use here is to make the logging
config from the *runner* be inherited by the *workers* too, which
helps with debugging quite a bit.
@yuvipanda
Copy link
Collaborator Author

@moradology that sounds like a good way to proceed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants